Apply prettier to .yml files + consistent quote style (#57286)#57286
Closed
robhogan wants to merge 1 commit into
Closed
Apply prettier to .yml files + consistent quote style (#57286)#57286robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109151683. |
Comment on lines
+11
to
+20
| runs-on: ubuntu-latest | ||
| if: github.repository == 'react/react-native' | ||
| steps: | ||
| - name: rerun ${{ inputs.run_id }} | ||
| env: | ||
| GH_REPO: ${{ github.repository }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run watch ${{ inputs.run_id }} > /dev/null 2>&1 | ||
| gh run rerun ${{ inputs.run_id }} --failed |
Comment on lines
+11
to
+20
| runs-on: ubuntu-latest | ||
| if: github.repository == 'react/react-native' | ||
| steps: | ||
| - name: rerun ${{ inputs.run_id }} | ||
| env: | ||
| GH_REPO: ${{ github.repository }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run watch ${{ inputs.run_id }} > /dev/null 2>&1 | ||
| gh run rerun ${{ inputs.run_id }} --failed |
Summary: Pull Request resolved: #57286 We currently have a mix of quote styles in `.yml` files (AI summary below). This applies prettier and reformats everything to single quotes to align with defaults. Also fixes a couple of cases of over-indentation. ``` Single-quotes only (0 double-quoted scalars): analyze-pr.yml — 12 single, 0 double api-changes.yml — 3 single, 0 double check-for-reproducer.yml — 4 single, 0 double retry-workflow.yml — 1 single, 0 double Single-quote predominant > double: autorebase.yml 2 vs 1 create-draft-release.yml 8 vs 2 generate-changelog.yml 3 vs 2 on-issue-labeled.yml 7 vs 2 prebuild-ios-core.yml 59 vs 17 prebuild-ios-dependencies.yml 39 vs 1 stale-bot.yml 18 vs 15 test-all.yml 70 vs 27 Double-quote predominant > single: bump-podfile-lock.yml 1 vs 10 create-release.yml 3 vs 12 e2e-android-rntester.yml 2 vs 6 e2e-android-templateapp.yml 6 vs 13 e2e-ios-rntester.yml 2 vs 7 e2e-ios-templateapp.yml 2 vs 18 fantom-tests.yml 2 vs 7 monitor-new-issues.yml 3 vs 12 publish-npm.yml 42 vs 50 validate-cxx-api-snapshots.yml 2 vs 23 validate-dotslash-artifacts.yml 2 vs 5 Tie / 1-1: cache-reaper.yml 1 vs 1 close-pr.yml 1 vs 1 needs-attention.yml 2 vs 2 All files contain single quotes somewhere, but only those 4 are single-quote-exclusive. Most CI-heavy workflows — bump, create-release, e2e-, fantom, monitor, publish-npm, validate- — lean double-quoted, while the pr/issue automation, prebuild ios, test-all, and stale-bot lean single-quoted. ``` Changelog: [Internal] ___ Differential Revision: D109151683
61698c3 to
695b85c
Compare
|
This pull request has been merged in 738839c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We currently have a mix of quote styles in
.ymlfiles (AI summary below). This applies prettier and reformats everything to single quotes to align with defaults.Also fixes a couple of cases of over-indentation.
Changelog: [Internal]
Differential Revision: D109151683